Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: DocsPage Heading and Subheading anchor links #9060

Merged

Conversation

atanasster
Copy link
Member

What I did

Similar to MDX pages, added anchor links to Header and Subheader sections in DocsPage

How to test

in DocsPage ( Addons/Docs/stories in official-storybook) hover over the Stories hading or the individual stories names (Subheading) and select the anchor element

@vercel
Copy link

vercel bot commented Dec 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/m1sradiqj
🌍 Preview: https://monorepo-git-fork-atanasster-docspage-headings-anchor-links.storybook.now.sh

@shilman shilman changed the title enhanced Heading and Subheading with HeaderMax Addon-docs: Heading and Subheading anchor links Dec 5, 2019
@shilman shilman added this to the 5.3.0 milestone Dec 5, 2019
@shilman shilman changed the title Addon-docs: Heading and Subheading anchor links Addon-docs: DocsPage Heading and Subheading anchor links Dec 5, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even cleaner than I'd expected!!! 💯

@shilman shilman merged commit 14df7d5 into storybookjs:next Dec 5, 2019
@shilman shilman deleted the docspage-headings-anchor-links branch December 5, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants